Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.12] [Ingest Pipelines] Add generated copy for all processors (#95507) #96660

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

jloleysens
Copy link
Contributor

Backports the following commits to 7.12:

* - minor refactor of 'description' -> 'typeDescription' for
  generic processor descriptions
- added initial pass of generated descriptions for all processors

* fix i18n

* added wrapping div and title to description and changed default description to appear as placeholder

* reworked the description width and overflow styling

* only show the text title on hover when we are not showing the text input

* fixed a number of minor issues with using values as though they are strings and doing better serialization

* slight optimisation to scss

* - implement copy feedback
- clean up a lot of uses of "target_field = field". it is better
  to not show these
- made "replacement" a required field on gsub (which it was not)

* revert the previouis validation as empty values are acceptbale for the replacement text

* - updated the copy per feedback and fixed a missing i18n.translate
- slight update to SCSS classes to not have unused class

* Added an empty string field validator that accepts spaces so that
the KV processor value and field split fields accept " "

* replace use of HTML "title" with EuiToolTip

* remove unused variable and import

* implemented feedback; removed if from default descriptions and other minor updates

* update default description of foreach to always display

Co-authored-by: Kibana Machine <[email protected]>
@jloleysens jloleysens enabled auto-merge (squash) April 8, 2021 21:44
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 725.0KB 736.9KB +12.0KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 0b111dc into elastic:7.12 Apr 8, 2021
@jloleysens jloleysens deleted the backport/7.12/pr-95507 branch April 12, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants